Github user jsnowacki commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19370#discussion_r143355412
  
    --- Diff: bin/find-spark-home.cmd ---
    @@ -0,0 +1,44 @@
    +@echo off
    +
    +rem
    +rem Licensed to the Apache Software Foundation (ASF) under one or more
    +rem contributor license agreements.  See the NOTICE file distributed with
    +rem this work for additional information regarding copyright ownership.
    +rem The ASF licenses this file to You under the Apache License, Version 2.0
    +rem (the "License"); you may not use this file except in compliance with
    +rem the License.  You may obtain a copy of the License at
    +rem
    +rem    http://www.apache.org/licenses/LICENSE-2.0
    +rem
    +rem Unless required by applicable law or agreed to in writing, software
    +rem distributed under the License is distributed on an "AS IS" BASIS,
    +rem WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
    +rem See the License for the specific language governing permissions and
    +rem limitations under the License.
    +rem
    +
    +rem Path to Python script finding SPARK_HOME
    +set FIND_SPARK_HOME_SCRIPT=%~dp0find_spark_home.py
    +
    +rem Default to standard python interpreter unless told otherwise
    +set PYTHON_RUNNER=python
    --- End diff --
    
    The order is different due to the limitations of CMDs. First, the variables 
are not correctly evaluated in side blocks of code in parenthesis; see [this 
post](https://superuser.com/questions/78496/variables-in-batch-file-not-being-set-when-inside-if).
 Second, there is no `else if` notion. I could do nested ifs but than I'll have 
the variable issue again. I tried to be as close to the original one as 
possible.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to