Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18747#discussion_r144933968
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarBatchScan.scala 
---
    @@ -84,6 +82,7 @@ private[sql] trait ColumnarBatchScan extends 
CodegenSupport {
         val columnarBatchClz = classOf[ColumnarBatch].getName
         val batch = ctx.freshName("batch")
         ctx.addMutableState(columnarBatchClz, batch, s"$batch = null;")
    +    val cachedBatch = ctx.freshName("cachedBatch")
    --- End diff --
    
    is this needed?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to