Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19494#discussion_r145219348
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/InMemoryColumnarQuerySuite.scala
 ---
    @@ -429,4 +429,19 @@ class InMemoryColumnarQuerySuite extends QueryTest 
with SharedSQLContext {
           checkAnswer(agg_without_cache, agg_with_cache)
         }
       }
    +
    +  test("SPARK-22249: IN should work also with cached DataFrame") {
    --- End diff --
    
    This test case is just an end-to-end test. This test will still pass if the 
optimizer has a change. We also need a unit test case. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to