[GitHub] spark pull request #19520: [SPARK-22298][WEB-UI]url encode API id before gen...

[alexnaspo]

GitHub user alexnaspo opened a pull request:

    https://github.com/apache/spark/pull/19520

    [SPARK-22298][WEB-UI]url encode API id before generating rest endpoint for 
/allexecutors

    ## What changes were proposed in this pull request?
    
    Spark Executor Page will return a blank list when the application id 
contains a forward slash. You can see the /allexecutors api failing with a 404. 
This can be fixed trivially by url encoding the appId before making the call to 
`/api/v1/applications/<appId>/allexecutors` in executorspage.js.
    
    ## How was this patch tested?
    <img width="1035" alt="screen shot 2017-10-17 at 2 50 11 pm" 
src="https://user-images.githubusercontent.com/1855262/31683573-595e4be2-b34b-11e7-9974-3886fcf766fe.png";>
    <img width="1347" alt="screen shot 2017-10-17 at 2 57 36 pm" 
src="https://user-images.githubusercontent.com/1855262/31683659-90b0eae6-b34b-11e7-9018-5b271de9db28.png";>
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alexnaspo/spark 
SPARK-22298-executors-url-encode

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19520.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19520
    
----
commit d4ce59685a3d44fbb46d8edfab9bc06e6dae1a41
Author: Alex Naspo <alex.na...@gmail.com>
Date:   2017-10-17T18:53:50Z

    url encode API id before generating rest endpoint for /allexecutors

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org