Github user susanxhuynh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19437#discussion_r145282997
  
    --- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
 ---
    @@ -122,7 +126,8 @@ private[mesos] object MesosSchedulerBackendUtil extends 
Logging {
         .toList
       }
     
    -  def containerInfo(conf: SparkConf): ContainerInfo.Builder = {
    +  def buildContainerInfo(conf: SparkConf, secretConfig: MesosSecretConfig):
    --- End diff --
    
    I've removed that second parameter and moved the secret stuff out of this 
method, since it's called by Fine-Grained mode, and we don't want to touch 
Fine-Grained mode.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to