Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19536#discussion_r145678163
--- Diff: project/MimaExcludes.scala ---
@@ -1043,6 +1043,9 @@ object MimaExcludes {
// [SPARK-21680][ML][MLLIB]optimzie Vector coompress
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.mllib.linalg.Vector.toSparseWithSize"),
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.ml.linalg.Vector.toSparseWithSize")
+ ) ++ Seq(
+ // [SPARK-6685][ML]Use DSYRK to compute AtA in ALS
+
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.recommendation.ALS.train")
--- End diff --
This breaks an API unnecessarily, even though it's a dev API. I think we
instead need to remove this as a user-facing param and avoid it altogether.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]