GitHub user ericjperry opened a pull request:
https://github.com/apache/spark/pull/19537
[SQL] Mark strategies with override for clarity.
## What changes were proposed in this pull request?
This is a very trivial PR, simply marking `strategies` in `SparkPlanner`
with the `override` keyword for clarity since it is overriding `strategies` in
`QueryPlanner` two levels up in the class hierarchy. I was reading through the
code to learn a bit and got stuck on this fact for a little while, so I figured
this may be helpful so that another developer new to the project doesn't get
stuck where I was.
I did not make a JIRA ticket for this because it is so trivial, but I'm
happy to do so to adhere to the contribution guidelines if required.
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration
tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise,
remove this)
Please review http://spark.apache.org/contributing.html before opening a
pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ericjperry/spark override-strategies
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19537.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19537
----
commit 69f041f1420be262006163bb64c39daa205e7209
Author: Eric Perry <[email protected]>
Date: 2017-10-19T13:05:16Z
Mark strategies as override for clarity.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
