Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17100#discussion_r146121901
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
 ---
    @@ -270,12 +273,25 @@ trait CheckAnalysis extends PredicateHelper {
     
             operator match {
               case o if o.children.nonEmpty && o.missingInput.nonEmpty =>
    +            val resolver = conf.resolver
    +            val commonAttrs = o.missingInput.filter(x =>
    +              o.inputSet.exists(y => resolver(x.name, y.name)))
                 val missingAttributes = o.missingInput.mkString(",")
    -            val input = o.inputSet.mkString(",")
    +            val availableAttributes = o.inputSet.mkString(",")
    +            val repeatedNameHint = if (commonAttrs.size > 0) {
    +              val commonNames = commonAttrs.map(_.name).mkString(",")
    +              s"""\n|Observe that attribute(s) $commonNames appear in two
    --- End diff --
    
    I'm not sure if this is always the case. Some failures in the query plan 
analysis can cause missing attributes, I mean.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to