Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19548#discussion_r146147293
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala 
---
    @@ -815,6 +815,12 @@ class JDBCSuite extends SparkFunSuite
           Some(DecimalType(DecimalType.MAX_PRECISION, 10)))
         assert(oracleDialect.getCatalystType(java.sql.Types.NUMERIC, 
"numeric", 0, null) ==
           Some(DecimalType(DecimalType.MAX_PRECISION, 10)))
    +    assert(oracleDialect.getCatalystType(100, "BINARY_FLOAT", 0, null) ==
    --- End diff --
    
    Let's define constants somewhere suitable for 100/100/-101


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to