Github user akopich commented on a diff in the pull request:
https://github.com/apache/spark/pull/19565#discussion_r146804206
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -497,40 +495,38 @@ final class OnlineLDAOptimizer extends LDAOptimizer
with Logging {
(u._1, u._2, u._3 + v._3)
}
- val (statsSum: BDM[Double], logphatOption: Option[BDV[Double]],
nonEmptyDocsN: Long) = stats
+ val (statsSum: BDM[Double], logphatOption: Option[BDV[Double]],
batchSize: Long) = stats
.treeAggregate((BDM.zeros[Double](k, vocabSize),
logphatPartOptionBase(), 0L))(
elementWiseSum, elementWiseSum
)
--- End diff --
Yes, that's right. But on the other hand, we've currently got a rather
simple `treeAggregate` so it barely contributes to the complexity of the code.
Anyway, is it OK to fix this in this issue?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
