Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19480#discussion_r146905964
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -78,6 +79,20 @@ case class SubExprEliminationState(isNull: String,
value: String)
case class SubExprCodes(codes: Seq[String], states: Map[Expression,
SubExprEliminationState])
/**
+ * The main information about a new added function.
+ *
+ * @param functionName String representing the name of the function
+ * @param subclassName Optional value which is empty if the function is
added to
+ * the outer class, otherwise it contains the name of
the
+ * inner class in which the function has been added.
+ * @param subclassInstance Optional value which is empty if the function
is added to
+ * the outer class, otherwise it contains the name
of the
+ * instance of the inner class in the outer class.
+ */
+private[codegen] case class NewFunction(functionName: String,
subclassName: Option[String],
+ subclassInstance: Option[String])
--- End diff --
See the link:
https://github.com/databricks/scala-style-guide#spacing-and-indentation
If it does not fit one line, we do it like
```Scala
private[codegen] case class NewFunction(
functionName: String,
subclassName: Option[String],
subclassInstance: Option[String])
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
