Github user sathiyapk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19451#discussion_r146977529
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/PropagateEmptyRelationSuite.scala
 ---
    @@ -30,6 +30,7 @@ class PropagateEmptyRelationSuite extends PlanTest {
           Batch("PropagateEmptyRelation", Once,
             CombineUnions,
             ReplaceDistinctWithAggregate,
    +        ReplaceExceptWithFilter,
    --- End diff --
    
    @gatorsmile Please let me know if you think it's not useful here, also the
    def replaceExceptWithFilter: Boolean = getConf(REPLACE_EXCEPT_WITH_FILTER) 
from the SQLConf, i'll push a new version with all the modifications, thanks.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to