Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/19571
  
    Thank you for review, @gatorsmile and @cloud-fan . Especially, @cloud-fan 
's opinion is my original approach in #17980 and #18953 (before Aug 16). I 
cannot agree any more.
    
    > Basically we leave the old orc data source as it is, and implement a new 
orc 1.4.1 data source in sql core module. Then we have an internal config to 
switch the implementation(by default prefer the new implementation), and remove 
the old implementation after one or two releases.
    
    BTW, I'm wondering what is changed after you commented [the 
following](https://github.com/apache/spark/pull/18953#issuecomment-322827590) 
on that PR on 16th Aug.
    
    > Are the ORC APIs changed a lot in 1.4? I was expecting a small patch to 
upgrade the current ORC data source, without moving it to sql/core.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to