Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19510#discussion_r147121858
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -64,6 +64,7 @@ private[spark] class MesosCoarseGrainedSchedulerBackend(
private val MAX_SLAVE_FAILURES = 2
private val maxCoresOption =
conf.getOption("spark.cores.max").map(_.toInt)
+ private val maxMemOption =
conf.getOption("spark.mem.max").map(Utils.memoryStringToMb)
--- End diff --
Do we need to have a check similar to
https://github.com/apache/spark/blob/06df34d35ec088277445ef09cfb24bfe996f072e/resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala#L73
but for memory, so that we know we'll "land" on the maximum?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
