Github user susanxhuynh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19437#discussion_r147162791
  
    --- Diff: docs/running-on-mesos.md ---
    @@ -485,39 +485,87 @@ See the [configuration page](configuration.html) for 
information on Spark config
     </tr>
     
     <tr>
    -  <td><code>spark.mesos.driver.secret.envkeys</code></td>
    -  <td><code>(none)</code></td>
       <td>
    -    A comma-separated list that, if set, the contents of the secret 
referenced
    -    by spark.mesos.driver.secret.names or spark.mesos.driver.secret.values 
will be
    -    set to the provided environment variable in the driver's process.
    +    <code>spark.mesos.driver.secret.values</code>,
    +    <code>spark.mesos.driver.secret.names</code>,
    +    <code>spark.mesos.executor.secret.values</code>,
    +    <code>spark.mesos.executor.secret.names</code>,
       </td>
    -  </tr>
    -  <tr>
    -<td><code>spark.mesos.driver.secret.filenames</code></td>
       <td><code>(none)</code></td>
       <td>
    -    A comma-separated list that, if set, the contents of the secret 
referenced by
    -    spark.mesos.driver.secret.names or spark.mesos.driver.secret.values 
will be
    -    written to the provided file. Paths are relative to the container's 
work
    -    directory.  Absolute paths must already exist.  Consult the Mesos 
Secret
    -    protobuf for more information.
    +    A secret is specified by its contents and destination. These properties
    +    specify a secret's contents. To specify a secret's destination, see 
the cell below.
    +
    +    You can specify a secret's contents either (1) by value or (2) by 
reference.
    +    (1) To specify a secret by value, set the
    +    <code>spark.mesos.[driver|executor].secret.values</code>
    +    property, to make the secret available in the driver or executors.
    +    For example, to make a secret password "guessme" available to the 
driver process, set:
    +    
    +    <pre>spark.mesos.driver.secret.values=guessme</pre>
    +    
    +    (2) To specify a secret that has been placed in a secret store
    --- End diff --
    
    I added a note about this. The secret store has to be provided by the user. 
You can configure Mesos to integrate with a secret store via a custom Mesos 
module.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to