Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19583#discussion_r147526524
--- Diff: core/src/test/scala/org/apache/spark/HeartbeatReceiverSuite.scala
---
@@ -225,6 +270,7 @@ class HeartbeatReceiverSuite
Matchers.eq(Array(1L -> metrics.accumulators())),
Matchers.eq(blockManagerId))
}
+ expectedUpdatedEpoch.foreach{_ => assert(response.updatedEpoch ===
expectedUpdatedEpoch)}
--- End diff --
don't you want to do this assert even if the expectedUpdate is `None`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
