Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19602#discussion_r147583510
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveClientSuite.scala
---
@@ -53,7 +52,7 @@ class HiveClientSuite(version: String)
for {
ds <- 20170101 to 20170103
h <- 0 to 23
- chunk <- Seq("aa", "ab", "ba", "bb")
+ chunk <- Seq("11", "12", "21", "22")
--- End diff --
Thanks a lot for review :)
I did two things:
1. Pass resolved `Expression` to generate filter -- because in current
change, I need data type of the attribute;
2. "aa" -> "11", "ab" -> "12", "ba" -> "21", "bb" -> "22" -- because I need
to pass an integer to set up the filter(chunk=11) and do the cast then.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
