Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19553#discussion_r147632343
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaUtils.scala ---
@@ -43,10 +43,17 @@ private[spark] object JavaUtils {
override def size: Int = underlying.size
- override def get(key: AnyRef): B = try {
- underlying.getOrElse(key.asInstanceOf[A], null.asInstanceOf[B])
- } catch {
- case ex: ClassCastException => null.asInstanceOf[B]
+ // Delegate to implementation because AbstractMap implementation
iterates over whole key set
+ override def containsKey(key: AnyRef): Boolean = {
+ underlying.contains(key.asInstanceOf[A])
--- End diff --
Yeah for historical reasons the signature has a key of type AnyRef instead
of A (pre-generics compatibility) and so the behavior for a key of the wrong
class can go either way:
https://docs.oracle.com/javase/8/docs/api/java/util/Collection.html#optional-restrictions
We should probably just keep the behavior.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
