GitHub user wzhfy opened a pull request:
https://github.com/apache/spark/pull/19610
[SPARK-22400] [SQL] rename some APIs and classes to make their meaning
clearer
## What changes were proposed in this pull request?
Both `ReadSupport` and `ReadTask` have a method called `createReader`, but
they create different things. This could cause some confusion for data source
developers. The same problem exists between `WriteSupport` and
`DataWriterFactory`, both of which have a method called `createWriter`. This PR
renames the method of `ReadTask`/`DataWriterFactory` to
`createDataReader`/`createDataWriter`.
Besides, the name of `RowToInternalRowDataWriterFactory` is not correct,
because it actually converts `InternalRow`s to `Row`s. It should be renamed
`InternalRowDataWriterFactory`.
## How was this patch tested?
Only renaming, should be covered by existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wzhfy/spark rename
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19610.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19610
----
commit 12a37030fe477cac2d165cdfa99bfb4170dfbafc
Author: Zhenhua Wang <[email protected]>
Date: 2017-10-30T15:58:17Z
do some rename
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
