Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/19623#discussion_r148325560
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataWriter.java
---
@@ -72,7 +74,7 @@
* should still "hide" the written data and ask the {@link
DataSourceV2Writer} at driver side to
* do the final commitment via {@link WriterCommitMessage}.
*
- * If this method fails(throw exception), {@link #abort()} will be
called and this data writer is
+ * If an exception was thrown, {@link #abort()} would be called and this
data writer was
* considered to be failed.
*/
WriterCommitMessage commit();
--- End diff --
should throw IOE as well, if possible
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
