Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19588#discussion_r148442709
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/VectorIndexer.scala ---
@@ -287,9 +315,12 @@ class VectorIndexerModel private[ml] (
while (featureIndex < numFeatures) {
if (categoryMaps.contains(featureIndex)) {
// categorical feature
- val featureValues: Array[String] =
+ var featureValues: Array[String] =
--- End diff --
minor: this can still be a val with if else, right?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
