Github user tejasapatil commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17644#discussion_r148558587
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
 ---
    @@ -247,7 +247,7 @@ abstract class ExternalCatalogSuite extends 
SparkFunSuite with BeforeAndAfterEac
         val catalog = newBasicCatalog()
         val tbl1 = catalog.getTable("db2", "tbl1")
         val newSchema = StructType(Seq(
    -      StructField("new_field_1", IntegerType),
    +      StructField("col1", IntegerType),
    --- End diff --
    
    yes. This was done because before this PR the test case was removing 
bucketed columns in the alter operation. We decided to disallow removing 
bucketing columns and support this if needed in future. 
    
    Here is the discussion that we both had about this : 
https://github.com/apache/spark/pull/17644#discussion_r114784136
    



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to