Github user tengpeng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19638#discussion_r148626297
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/evaluation/RegressionEvaluator.scala 
---
    @@ -49,8 +49,8 @@ final class RegressionEvaluator @Since("1.4.0") 
(@Since("1.4.0") override val ui
        */
       @Since("1.4.0")
       val metricName: Param[String] = {
    -    val allowedParams = ParamValidators.inArray(Array("mse", "rmse", "r2", 
"mae"))
    -    new Param(this, "metricName", "metric name in evaluation 
(mse|rmse|r2|mae)", allowedParams)
    +    val allowedParams = ParamValidators.inArray(Array("mse", "rmse", "r2", 
"r2adj", "mae"))
    +    new Param(this, "metricName", "metric name available 
(mse|rmse|r2|r2adj|mae)", allowedParams)
    --- End diff --
    
    This is simply because the length of line is > 100 if I keep "in 
evaluation". I am ok to keep it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to