Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2674#discussion_r18684292
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScan.scala 
---
    @@ -80,10 +80,15 @@ case class HiveTableScan(
         ColumnProjectionUtils.appendReadColumnIDs(hiveConf, neededColumnIDs)
         ColumnProjectionUtils.appendReadColumnNames(hiveConf, 
attributes.map(_.name))
     
    +    val td = relation.tableDesc
    +    val deClass = td.getDeserializerClass;
    +    val de = deClass.newInstance();
    --- End diff --
    
    In general we try to use descriptive variable names instead of short one.  
Also we do not use `;`s
    
    ```scala
    val deserializer = relation.tableDesc.getDeserializerClass.newInstance()
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to