Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/16578#discussion_r148725482 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/FileSchemaPruningTest.scala --- @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution + +import org.scalactic.Equality +import org.scalatest.Assertions + +import org.apache.spark.sql.DataFrame +import org.apache.spark.sql.catalyst.parser.CatalystSqlParser +import org.apache.spark.sql.types.StructType + +private[sql] trait FileSchemaPruningTest { + _: Assertions => + + private val schemaEquality = new Equality[StructType] { + override def areEqual(a: StructType, b: Any) = + b match { + case otherType: StructType => a sameType otherType + case _ => false + } + } + + protected def checkScanSchemata(df: DataFrame, expectedSchemaCatalogStrings: String*): Unit = { + val fileSourceScanSchemata = --- End diff -- `fileSourceScanSchemata` is a `Seq[StructType]`, so I made it plural.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org