Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19646#discussion_r148770218
--- Diff: python/pyspark/sql/session.py ---
@@ -416,6 +417,50 @@ def _createFromLocal(self, data, schema):
data = [schema.toInternal(row) for row in data]
return self._sc.parallelize(data), schema
+ def _getNumpyRecordDtypes(self, rec):
--- End diff --
I know it's confusing .. but I usually use thisNamingRule mainly on the
purpose of API consistency and otherwise use this_naming_rule. I actually
checked and read documentation and other codes few times for clarification for
myself .. I believe this_naming_rule is preferred by PEP 8.
But I know that the
[doc](https://www.python.org/dev/peps/pep-0008/#function-names) says:
> mixedCase is allowed only in contexts where that's already the prevailing
style (e.g. threading.py), to retain backwards compatibility.
but .. I believe we should avoid thisNamingRule if it's in particular for
internal use and/or unrelated with compatibility. Up to my knowledge,
`threading.py` is the similar case I believe ...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
