Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19649#discussion_r148783570
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -147,7 +154,15 @@ abstract class ExternalCatalog
* Note: If the underlying implementation does not support altering a
certain field,
* this becomes a no-op.
*/
- def alterTable(tableDefinition: CatalogTable): Unit
+ final def alterTable(tableDefinition: CatalogTable): Unit = {
--- End diff --
I'd suggest we leave it for now and watch other `alterTableXXX` events
instead. I feel it's an overkill to have a heavy `alterTable` method to
handling all table metadata updating, I think we will add more and more
fine-grained alter table methods in the future, like `alterTableStats`,
`alterTableDataSchema`, etc. and eventually this `alterTable` method will go
away.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
