Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19623#discussion_r148848790
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/DataReader.java 
---
    @@ -34,11 +35,17 @@
     
       /**
        * Proceed to next record, returns false if there is no more records.
    +   *
    +   * If this method fails (by throwing an exception), the corresponding 
Spark task would fail and
    +   * get retried until hitting the maximum retry times.
        */
    -  boolean next();
    +  boolean next() throws IOException;
    --- End diff --
    
    Should clarify when it is okay to throw IOException with `@throws`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to