Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19653#discussion_r148865915
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/NullHandlingSuite.scala ---
    @@ -0,0 +1,130 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.sql
    +
    +import org.apache.spark.sql.functions._
    +import org.apache.spark.sql.test.SharedSQLContext
    +
    +case class T1(a: Int, b: Option[Int], c: Option[Int])
    +
    +/**
    + * This test suite takes https://sqlite.org/nulls.html as a reference.
    + */
    +class NullHandlingSuite extends QueryTest with SharedSQLContext {
    --- End diff --
    
    Maybe using SQL? It will be easier for the others who knew SQL only to 
understand our NULL handling logics. Thanks again!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to