Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19582#discussion_r148913864
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -486,8 +580,21 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
bus.addListener(listener)
replay(fileStatus, isApplicationCompleted(fileStatus), bus,
eventsFilter)
- listener.applicationInfo.foreach(addListing)
- listing.write(LogInfo(logPath.toString(), fileStatus.getLen()))
+ listener.applicationInfo.foreach { app =>
+ // Invalidate the existing UI for the reloaded app attempt, if any.
Note that this does
+ // not remove the UI from the active list; that has to be done in
onUIDetached, so that
+ // cleanup of files can be done in a thread-safe manner. It does
mean the UI will remain
+ // in memory for longer than it should.
--- End diff --
Done. Also updated a bunch of other stale comments.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
