Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19651#discussion_r148935499
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcOutputWriter.scala
 ---
    @@ -0,0 +1,59 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.execution.datasources.orc
    +
    +import org.apache.hadoop.fs.Path
    +import org.apache.hadoop.io.NullWritable
    +import org.apache.hadoop.mapreduce._
    +import org.apache.orc.mapred.OrcStruct
    +import org.apache.orc.mapreduce.OrcOutputFormat
    +
    +import org.apache.spark.sql.catalyst.InternalRow
    +import org.apache.spark.sql.execution.datasources.OutputWriter
    +import org.apache.spark.sql.types.StructType
    +
    +private[orc] class OrcOutputWriter(
    +    path: String,
    +    dataSchema: StructType,
    +    context: TaskAttemptContext)
    +  extends OutputWriter {
    +  private lazy val orcStruct: OrcStruct =
    +    OrcUtils.createOrcValue(dataSchema).asInstanceOf[OrcStruct]
    +
    +  private[this] val writableWrappers =
    +    dataSchema.fields.map(f => OrcUtils.getWritableWrapper(f.dataType))
    +
    +  private val recordWriter = {
    +    new OrcOutputFormat[OrcStruct]() {
    +      override def getDefaultWorkFile(context: TaskAttemptContext, 
extension: String): Path = {
    +        new Path(path)
    +      }
    +    }.getRecordWriter(context)
    +  }
    +
    +  override def write(row: InternalRow): Unit = {
    +    recordWriter.write(
    +      NullWritable.get,
    +      OrcUtils.convertInternalRowToOrcStruct(
    --- End diff --
    
    ideally we should make it into a function a use it in `write`, like the old 
`OrcOutputWriter` did.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to