Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2570#discussion_r18685778
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
    @@ -67,37 +76,160 @@ private[hive] class HiveMetastoreCatalog(hive: 
HiveContext) extends Catalog with
           table.getTTable, partitions.map(part => part.getTPartition))(hive)
       }
     
    +  /**
    +   * Create table with specified database, table name, table description 
and schema
    +   * @param databaseName Database Name
    +   * @param tableName Table Name
    +   * @param schema Schema of the new table, if not specified, will use the 
schema
    +   *               specified in crtTbl
    +   * @param allowExisting if true, ignore AlreadyExistsException
    +   * @param crtTbl CreateTableDesc object which contains the SerDe info. 
Currently
    +   *               we support most of the features except the bucket.
    +   */
       def createTable(
           databaseName: String,
           tableName: String,
           schema: Seq[Attribute],
    -      allowExisting: Boolean = false): Unit = {
    +      allowExisting: Boolean = false,
    +      crtTbl: CreateTableDesc = null) {
    --- End diff --
    
    I'd prefer `Option`s to `null`s


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to