Github user zhouyejoe commented on the issue:

    https://github.com/apache/spark/pull/19170
  
    @jiangxb1987 Hi, I was waiting for the response from Ryan Blue about the 
ticket SPARK-20084. The fix for the unit test should be pretty straight 
forward. I just need a confirmation on the question I have. Do you have any 
idea?
    
    Original question:
    why not the blockstatusupdates are not filtering out in 
executorMetricsUpdate? This line 
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/util/JsonProtocol.scala#L245
    While I am working on SPARK-21961, I filtered those blockstatusupdates 
while reading from logs in Spark History Server, but it causing some unit test 
failure.
    Should it not be filtered out in both executorMetricsUpdateFromJson and 
executorMetricsUpdateToJson?
    Thanks.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to