Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19680#discussion_r149216754
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/summary/ClusteringSummary.scala ---
@@ -30,11 +30,12 @@ import org.apache.spark.sql.{DataFrame, Row}
* @param k Number of clusters.
*/
@Experimental
-class ClusteringSummary private[clustering] (
- @transient val predictions: DataFrame,
- val predictionCol: String,
- val featuresCol: String,
- val k: Int) extends Serializable {
+// TODO: make this a trait?
+class ClusteringSummary private[ml] (
--- End diff --
this is never used directly, so I can't think of why this shouldn't be a
trait. It would break compatibility at this point, but since it's experimental
it may be permissible?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
