Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19666#discussion_r149242575
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -976,6 +930,44 @@ private[spark] object RandomForest extends Logging {
categories
}
+ private[tree] def traverseUnorderedSplits[T](
--- End diff --
Also, does `traverseUnorderedSplits` need to take a type parameter / two
different closures as method arguments? AFAICT the use of a type
parameter/closures here allow us to unit test this functionality on a simple
example, but I wonder if we could simplify this somehow.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
