Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19681#discussion_r149466906
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLListenerSuite.scala
 ---
    @@ -36,13 +36,14 @@ import org.apache.spark.sql.catalyst.util.quietly
     import org.apache.spark.sql.execution.{LeafExecNode, QueryExecution, 
SparkPlanInfo, SQLExecution}
     import org.apache.spark.sql.execution.metric.{SQLMetric, SQLMetrics}
     import org.apache.spark.sql.test.SharedSQLContext
    -import org.apache.spark.ui.SparkUI
    +import org.apache.spark.status.config._
     import org.apache.spark.util.{AccumulatorMetadata, JsonProtocol, 
LongAccumulator}
    -
    +import org.apache.spark.util.kvstore.InMemoryStore
     
     class SQLListenerSuite extends SparkFunSuite with SharedSQLContext with 
JsonTestUtils {
    --- End diff --
    
    Actually this suite has a mix of tests for the listener and for stuff 
that's not related to the listener, which would belong in 
`SQLAppStatusListenerSuite`. My original changes broke this into two different 
suites, but I chose to postpone that to reduce the size of the diff for now 
(and also to make the diff a little easier to read).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to