Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19659#discussion_r149480386
--- Diff: examples/src/main/python/ml/n_gram_example.py ---
@@ -35,7 +35,7 @@
(2, ["Logistic", "regression", "models", "are", "neat"])
], ["id", "words"])
- ngram = NGram(n=2, inputCol="words", outputCol="ngrams")
+ ngram = NGram(n=2, maxN=4, inputCol="words", outputCol="ngrams")
--- End diff --
This generally isn't enough to expose the new functionality in Python. Take
a look in `feature.py` & also consider adding some Python tests.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
