Github user vundela commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19699#discussion_r149843907
  
    --- Diff: 
core/src/test/scala/org/apache/spark/metrics/MetricsSystemSuite.scala ---
    @@ -42,7 +43,7 @@ class MetricsSystemSuite extends SparkFunSuite with 
BeforeAndAfter with PrivateM
         val metricsSystem = MetricsSystem.createMetricsSystem("default", conf, 
securityMgr)
         metricsSystem.start()
         val sources = PrivateMethod[ArrayBuffer[Source]]('sources)
    -    val sinks = PrivateMethod[ArrayBuffer[Source]]('sinks)
    +    val sinks = PrivateMethod[ArrayBuffer[Sink]]('sinks)
    --- End diff --
    
    I thought the same, but tests are passing. So decided as nit fixes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to