Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19702#discussion_r149940418
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaSuite.scala
 ---
    @@ -982,7 +941,7 @@ class ParquetSchemaSuite extends ParquetSchemaTest {
         binaryAsString = true,
         int96AsTimestamp = false,
         writeLegacyParquetFormat = true,
    -    int64AsTimestampMillis = true)
    +    outputTimestampType = 
SQLConf.ParquetOutputTimestampType.TIMESTAMP_MILLIS)
    --- End diff --
    
    Should we add a test for `TIMESTAMP_MICROS` just in case?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to