Github user WeichenXu123 commented on the issue:

    https://github.com/apache/spark/pull/19666
  
    @facaiy Your idea looks also reasonable. So we can use the condition 
"exclude the first bin" to do the pruning (filter out the other half symmetric 
splits). This condition looks simpler than `1 <= combNumber <= numSplists`, 
`Good idea !
    And your code use another traverse order, my current PR is also 
backtracking, with different traverse order, but I think both of them works, 
and both of their complexity will be `O(2^n)`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to