Github user tashoyan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19700#discussion_r150052324
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala ---
    @@ -101,6 +101,8 @@ class SQLListener(conf: SparkConf) extends 
SparkListener with Logging {
     
       private val retainedExecutions = 
conf.getInt("spark.sql.ui.retainedExecutions", 1000)
     
    +  private val retainedStages = conf.getInt("spark.ui.retainedStages", 1000)
    --- End diff --
    
    @dongjoon-hyun , It is already documented in the same file configuration.md:
    ```
    How many stages the Spark UI and status APIs remember before garbage 
collecting.
    This is a target maximum, and fewer elements may be retained in some 
circumstances.
    ```
    I did not involve a new parameter, I just used an existing one.
    Regarding renaming to `spark.sql.ui.retainedStages`, I believe it should be 
done in a separate pull request - if should. This parameter is also used in 
other parts of Spark code, not only SQL.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to