Github user yaooqinn commented on a diff in the pull request:
https://github.com/apache/spark/pull/19712#discussion_r150161651
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
---
@@ -521,20 +521,7 @@ class HiveThriftBinaryServerSuite extends
HiveThriftJdbcTest {
conf += resultSet.getString(1) -> resultSet.getString(2)
}
- assert(conf.get("spark.sql.hive.version") === Some("1.2.1"))
- }
- }
-
- test("Checks Hive version via SET") {
- withJdbcStatement() { statement =>
- val resultSet = statement.executeQuery("SET")
-
- val conf = mutable.Map.empty[String, String]
- while (resultSet.next()) {
- conf += resultSet.getString(1) -> resultSet.getString(2)
- }
-
- assert(conf.get("spark.sql.hive.version") === Some("1.2.1"))
--- End diff --
the first commit fails this ut checking spark.sql.hive.metastore.version.
`set` cmd only shows the changed variables, if more unit tests are needed, i
can add some.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
