Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19170#discussion_r150261879
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -739,6 +733,16 @@ private[spark] object JsonProtocol {
taskInfo
}
+ def accumulablesFromJson(json: Option[JValue]):
Option[Seq[AccumulableInfo]] = {
--- End diff --
Why not just accept a `JValue` hereï¼
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
