Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19689#discussion_r150269521
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2579,8 +2579,10 @@ class Dataset[T] private[sql](
* @group action
* @since 1.6.0
*/
- def foreach(f: T => Unit): Unit = withNewExecutionId {
- rdd.foreach(f)
+ def foreach(f: T => Unit): Unit = {
+ withNewRDDExecutionId {
--- End diff --
we can follow the previous style: `def foreach ... = withNewRDDExecutionId
{`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
