Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18972#discussion_r150299574
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
    @@ -2067,7 +2067,7 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
           .count
       }
     
    -  testQuietly("SPARK-19372: Filter can be executed w/o generated code due 
to JVM code size limit") {
    +  test("SPARK-19372: Filter can be executed w/o generated code due to JVM 
code size limit") {
    --- End diff --
    
    I think this test case becomes invalid as we won't trigger the codegen 
fallback branch now. Can we just ignore this test and add a TODO to say 
something about the config?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to