[GitHub] spark pull request #19719: [SPARK-22487][SQL][followup] still keep spark.sql...

[yaooqinn]

Github user yaooqinn commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19719#discussion_r150368111
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala 
---
    @@ -66,6 +66,12 @@ private[spark] object HiveUtils extends Logging {
         .stringConf
         .createWithDefault(builtinHiveVersion)
     
    +  // A deprecated config which is only used to provide a default value, in 
case some existing
    +  // applications depend on this config, e.g. Spark SQL ODBC driver.
    --- End diff --
    
    if Thrift Server only works for 1.2.1，I guess we don’t need an isolated 
classload for its hive client like SparkSQLCLIDriver


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org