Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19729#discussion_r150420093
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -604,6 +604,8 @@ case class Least(children: Seq[Expression]) extends
Expression {
val evalChildren = children.map(_.genCode(ctx))
val first = evalChildren(0)
--- End diff --
Do you want to assign `evalChildren(0).value` into `ev.value` and then
compare all of `evalChildren`? It can avoid `rest` for cleaner code. However,
it increases one comparison.
Or, do you have another idea?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
