Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19525#discussion_r150432943
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -2769,6 +2769,20 @@ class LogisticRegressionSuite
LogisticRegressionSuite.allParamSettings, checkModelData)
}
+ test("read/write with BoundsOnCoefficients") {
+ def checkModelData(model: LogisticRegressionModel, model2:
LogisticRegressionModel): Unit = {
+ assert(model.getLowerBoundsOnCoefficients ===
model2.getLowerBoundsOnCoefficients)
+ assert(model.getUpperBoundsOnCoefficients ===
model2.getUpperBoundsOnCoefficients)
--- End diff --
The existing read/write test has `elasticNetParam = 0.1`.
I can update the `checkModelData` function here to check model
`coefficients` and `intercept` if it's OK with you.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
