Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15049#discussion_r150491004
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
 ---
    @@ -370,13 +372,11 @@ class ParquetFileFormat
           } else {
             logDebug(s"Falling back to parquet-mr")
             // ParquetRecordReader returns UnsafeRow
    -        val reader = pushed match {
    -          case Some(filter) =>
    -            new ParquetRecordReader[UnsafeRow](
    -              new ParquetReadSupport,
    -              FilterCompat.get(filter, null))
    -          case _ =>
    -            new ParquetRecordReader[UnsafeRow](new ParquetReadSupport)
    +        val reader = if (pushed.isDefined && enableRecordFilter) {
    --- End diff --
    
    It should be fine to make this change, I was thinking we could make this 
change by setting the value of `ParquetInputFormat.RECORD_FILTERING_ENABLED` to 
false. Both way works and I don't have strong preference. Sorry for the late 
response.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to