Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19733#discussion_r150542856
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -236,24 +236,38 @@ case class In(value: Expression, list:
Seq[Expression]) extends Predicate {
override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
val valueGen = value.genCode(ctx)
val listGen = list.map(_.genCode(ctx))
+ ctx.addMutableState("boolean", ev.value, "")
+ ctx.addMutableState("boolean", ev.isNull, "")
+ val valueArg = ctx.freshName("valueArg")
--- End diff --
At [this
line](https://github.com/apache/spark/pull/19733/files#diff-aec2bffff270efab6835320c7a1dc8e9R255),
we cannot use `valueGen.value` in some cases (e.g. ` (UTF8String)variable1`).
Then, we cannot use `valueGen.value` at [this
line](https://github.com/apache/spark/pull/19733/files#diff-aec2bffff270efab6835320c7a1dc8e9R248).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
